Conversation
It makes no sense to check the compiler or language. Currently this is relying on a declaration leaked out of the clang builtin headers, which should not be exporting ockl functions.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes unnecessary preprocessor guards around the __ockl_fdot2 function declaration. The change ensures this OCKL (Open Compute Kernel Library) function is always declared, eliminating the previous dependency on leaked declarations from Clang's builtin headers.
Key Changes:
- Removed conditional compilation checks (
__clang__and__HIP__) around__ockl_fdot2declaration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
This is trying to fix the build break with ROCm/llvm-project#793 |
kzhuravl
approved these changes
Dec 9, 2025
arsenm
deleted the
arsenm/swdev548892/add-missing-declaration-ockl-fdot2
branch
systems-assistant bot
pushed a commit
to ROCm/clr
that referenced
this pull request
Dec 11, 2025
available (#2229) [rocm-systems] ROCm/rocm-systems#2229 (commit a495d11)
xuchen-amd
pushed a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It makes no sense to check the compiler or language. Currently this is relying on a declaration leaked out of the clang builtin headers, which should not be exporting ockl functions.